fix(installer): throw an exception only if app store is also enabled#59617
Merged
joshtrichards merged 1 commit intomasterfrom Apr 24, 2026
Merged
fix(installer): throw an exception only if app store is also enabled#59617joshtrichards merged 1 commit intomasterfrom
joshtrichards merged 1 commit intomasterfrom
Conversation
leftybournes
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
leftybournes
force-pushed
the
fix/store-readonly-appfolder
branch
2 times, most recently
from
2aa3962 to
b50bb80
Compare
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
force-pushed
the
fix/store-readonly-appfolder
branch
from
b50bb80 to
69f5383
Compare
leftybournes
changed the title
CarlSchwan
approved these changes
Apr 14, 2026
come-nc
approved these changes
Apr 20, 2026
come-nc
reviewed
Apr 20, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
This is a bit hacky, 'writable' can simply be set to false in this case.
Member
|
At least now it matches the exception note about disabling the app store ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the app folders are readonly while the config contains
'appstoreenabled' => false, the app management admin page throws an exception and fails to load. This ignores any app folder's writeable permission if the app store is disabled.Checklist
3. to review, feature component)stable32)AI (if applicable)